[PATCH] D53676: [WebAssembly] Lower away condition truncations for scalar selects
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 24 18:00:36 PDT 2018
aheejin added a comment.
It seems only 1 can be a possible condition value from a valid LLVM IR, and if that's the case, I think what we need in this case is `UndefinedBooleanContent`. And I guess that should be the case for all other wasm instructions, but if we comment out this line <https://github.com/llvm-mirror/llvm/blob/7b105bc3a6c4795ad428e55713aedfa7edb27911/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp#L50>, a bunch of test fails... Not sure why we need that line and what makes this case exceptional. Could you check?
Repository:
rL LLVM
https://reviews.llvm.org/D53676
More information about the llvm-commits
mailing list