[PATCH] D53671: [X86] Remove some uarch tuning flags from KNL that look to have been inherited from SNB/IVB incorrectly
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 24 14:14:13 PDT 2018
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
KNL is based on a modified Silvermont core so I don't think these features apply. I think the LEA flag is probably also wrong, but I'm less sure as I barely understand the 3 LEA flags we have currently.
https://reviews.llvm.org/D53671
Files:
lib/Target/X86/X86.td
test/CodeGen/X86/avx512-select.ll
Index: test/CodeGen/X86/avx512-select.ll
===================================================================
--- test/CodeGen/X86/avx512-select.ll
+++ test/CodeGen/X86/avx512-select.ll
@@ -16,8 +16,8 @@
;
; X64-LABEL: select00:
; X64: # %bb.0:
-; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: cmpl $255, %edi
+; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: je .LBB0_2
; X64-NEXT: # %bb.1:
; X64-NEXT: vmovdqa64 %zmm0, %zmm1
@@ -44,8 +44,8 @@
;
; X64-LABEL: select01:
; X64: # %bb.0:
-; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: cmpl $255, %edi
+; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: je .LBB1_2
; X64-NEXT: # %bb.1:
; X64-NEXT: vmovdqa64 %zmm0, %zmm1
Index: lib/Target/X86/X86.td
===================================================================
--- lib/Target/X86/X86.td
+++ lib/Target/X86/X86.td
@@ -823,11 +823,7 @@
FeatureXSAVEOPT,
FeatureLAHFSAHF,
FeatureSlow3OpsLEA,
- FeatureFastScalarFSQRT,
- FeatureFastSHLDRotate,
FeatureSlowIncDec,
- FeatureMergeToThreeWayBranch,
- FeatureMacroFusion,
FeatureRDRAND,
FeatureF16C,
FeatureFSGSBase,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53671.170981.patch
Type: text/x-patch
Size: 1149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181024/0be9f4dd/attachment.bin>
More information about the llvm-commits
mailing list