[PATCH] D53384: [PowerPC] Make no-PIC default to match GCC - CLANG

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: test/Driver/ppc-abi.c:33
 // CHECK-ELFv2: "-target-abi" "elfv2"
 
----------------
jsji wrote:
> No sure whether this is correct place to add, but maybe we should add some test to make sure that adding -fPIC option will set the pic-level the same as before?
Good point. I'm going to add another option to check that -fPIC behaves as it did before.


================
Comment at: test/Driver/print-multi-directory.c:7
 
-// CHECK-X86-MULTILIBS:      32
+// CHECK-X86-MULTILIBS:      .
 // CHECK-X86-MULTILIBS-NOT:  {{^.+$}}
----------------
jsji wrote:
> Do we know why this changes due to fPIC default change?  
> If this is a non-relevant change, maybe deliver in another NFC commit? Thanks.
No I don't know exactly why this changes.
I was actually debating in this situation whether or not I should just add -fPIC to the options to keep the behaviour the same as before. 

Unfortunately I can't put this in a later NFC change because I would leave a failing test. I either have to adjust the test or I would have to add -fPIC. 


https://reviews.llvm.org/D53384