[PATCH] D53663: [X86] Add a common-avx512 CPU to match icc's -xCOMMON-AVX512 option

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: include/llvm/Support/X86TargetParser.def:70
 X86_CPU_TYPE                  ("k8-sse3",     AMD_K8SSE3)
+X86_CPU_TYPE                  ("common-avx512", INTEL_COMMON_AVX512)
 #undef X86_CPU_TYPE_COMPAT_WITH_ALIAS
----------------
Is there any reason in particular this isn't grouped with the other INTEL declarations above?  I don't know if it should be or not.  I assume eventually AMD will have an AVX512 offering and maybe common-avx512 can be used for both Intel and AMD targets.


================
Comment at: lib/Target/X86/X86.td:874
+]>;
+def : CommonAVX512Proc<"common-avx512">;
+
----------------
AVX512F is supposed to be the minimum support needed for common AVX512 functionality.  Instead of "common" throughout, would it make sense to just say "avx512f?"  "common-avx512" isn't a specification that exists anywhere, while "avx512f" is.


https://reviews.llvm.org/D53663