[PATCH] D53066: [Driver] Use forward slashes in most linker arguments

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 11:18:56 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D53066#1274288, @zturner wrote:

> It seems like some combination of checking the target triple, host triple,
>  and driver mode and putting the conversions behind those checks could work?


Sounds ok, I can give it a shot. There's probably no need to explicitly check the host here, as the `convert_to_slash` function is a no-op on anything else than windows.

> For paths like resource dir that are going into debug info it should be
>  driver mode.

Why is that? Wouldn't one want the same behaviour when building with the clang driver with an msvc target triple? Also, what kind of paths do you get in the PDB when crosscompiling from unix with clang-cl?


https://reviews.llvm.org/D53066





More information about the llvm-commits mailing list