[PATCH] D53519: [CodeGen] skip lifetime end marker in isInTailCallPosition

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL345163: [CodeGen] skip lifetime end marker in isInTailCallPosition (authored by rlougher, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53519?vs=170458&id=170925#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53519

Files:
  llvm/trunk/lib/CodeGen/Analysis.cpp
  llvm/trunk/test/CodeGen/X86/tailcall-lifetime-end.ll


Index: llvm/trunk/lib/CodeGen/Analysis.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/Analysis.cpp
+++ llvm/trunk/lib/CodeGen/Analysis.cpp
@@ -496,6 +496,10 @@
       // Debug info intrinsics do not get in the way of tail call optimization.
       if (isa<DbgInfoIntrinsic>(BBI))
         continue;
+      // A lifetime end intrinsic should not stop tail call optimization.
+      if (const IntrinsicInst *II = dyn_cast<IntrinsicInst>(BBI))
+        if (II->getIntrinsicID() == Intrinsic::lifetime_end)
+          continue;
       if (BBI->mayHaveSideEffects() || BBI->mayReadFromMemory() ||
           !isSafeToSpeculativelyExecute(&*BBI))
         return false;
Index: llvm/trunk/test/CodeGen/X86/tailcall-lifetime-end.ll
===================================================================
--- llvm/trunk/test/CodeGen/X86/tailcall-lifetime-end.ll
+++ llvm/trunk/test/CodeGen/X86/tailcall-lifetime-end.ll
@@ -0,0 +1,27 @@
+; RUN: llc -mtriple=x86_64-unknown-linux-gnu -o - %s | FileCheck %s
+
+; A lifetime end intrinsic should not prevent a call from being tail call
+; optimized.
+
+define void @foobar() {
+; CHECK-LABEL: foobar
+; CHECK: pushq	%rax
+; CHECK: leaq	4(%rsp), %rdi
+; CHECK: callq	foo
+; CHECK: popq	%rax
+; CHECK: jmp	bar
+entry:
+  %i = alloca i32
+  %0 = bitcast i32* %i to i8*
+  call void @llvm.lifetime.start.p0i8(i64 4, i8* nonnull %0)
+  call void @foo(i32* nonnull %i)
+  tail call void @bar()
+  call void @llvm.lifetime.end.p0i8(i64 4, i8* nonnull %0)
+  ret void
+}
+
+declare void @foo(i32* nocapture %p)
+declare void @bar()
+
+declare void @llvm.lifetime.start.p0i8(i64, i8* nocapture)
+declare void @llvm.lifetime.end.p0i8(i64, i8* nocapture)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53519.170925.patch
Type: text/x-patch
Size: 1729 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181024/752fbf9a/attachment.bin>