[PATCH] D53534: [hot-cold-split] Name split functions with ".cold" suffix

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D53534#1273174, @tejohnson wrote:

> In https://reviews.llvm.org/D53534#1273164, @xbolva00 wrote:
>
> > Does the pass groups hot code together? is it in your plans?
>
>
> @sebpop, @vsk or @hiraditya can probably answer this. I'm not working on the core hot cold splitting algorithm, just some issues I'm finding as I try it. But presumably the linker should be grouping the split hot functions together and the split cold functions together, when building with -ffunction-sections and PGO which should put them in the .text.hot and .text.unlikely sections, respectively.


The pass currently does not group hot or cold code together. Teresa's explanation is correct -- we'll need linker support to do that. On Darwin I have plans to implement this by adding a section modifier (similar to live_support), as this doesn't require creating a new section or messing with order files.


Repository:
  rL LLVM

https://reviews.llvm.org/D53534