[PATCH] D53576: [llvm-objdump] Add alias option `--full-contents` for `-s` (PR39404)

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 08:48:55 PDT 2018


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

Do you need me to commit it?

I have one inlined query about formatting. If you haven't clang-formatted the area, please do so before committing.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:119-123
+llvm::SectionContents("full-contents",
+  cl::desc("Display the content of each section"));
+static cl::alias
+SectionContentsShort("s", cl::desc("Alias for --full-contents"),
+             cl::aliasopt(SectionContents));
----------------
Have you clang-formatted this area?


https://reviews.llvm.org/D53576





More information about the llvm-commits mailing list