[PATCH] D52227: LLVM: Expose SimplifyCFGPass (as used in PassBuilder::buildModuleOptimizationPipeline) in PassRegistry.def

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D52227#1273643, @georgevdd wrote:

> - I am keen to supply appropriate tests but, as a newcomer, probably a poor judge of what appropriate looks like.


I don't have much experience with the pass manager level, but you probably want to have an IR test to confirm that the options set by "simplify-cfg-opt" are actually enabled by checking that the IR is transformed correctly. See the previously mentioned patches for possible examples.

> More generally, does it seem to you reasonable to aim to support the ability to represent exactly the default pipelines using the names of their elements? Or is the overall direction of development away from that?

I understand the goal, but I'm not sure how to best achieve it. If you've already discussed this idea with others, then it should be fine. I'll ask others to continue the review of this patch because I don't have more to say here.


Repository:
  rL LLVM

https://reviews.llvm.org/D52227