[PATCH] D53620: [WebAssembly] Error out when block/loop markers mismatch
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 24 04:39:44 PDT 2018
aheejin added a comment.
Hmm strange. The test currently fails after I switch to assertions. If we use `report_fatal_error`, the test runs fine. Not sure why.
-- Testing: 1 tests, 1 threads --
FAIL: LLVM :: MC/WebAssembly/block-mismatch.s (1 of 1)
******************** TEST 'LLVM :: MC/WebAssembly/block-mismatch.s' FAILED ********************
Script:
--
: 'RUN: at line 1'; not /usr/local/google/home/aheejin/llvm-git/build.debug/bin/llvm-mc -triple=wasm32-unknown-unknown /usr/local/google/home/aheejin/llvm-git/llvm/test/MC/WebAssembly/block-mismatch.s -o - 2>&1 | /usr/local/google/home/aheejin/llvm-git/build.debug/bin/FileCheck /usr/local/google/home/aheejin/llvm-git/llvm/test/MC/WebAssembly/block-mismatch.s
--
Exit Code: 1
But If I run that command manually, it succeeds. I think the reason might be the way `assert` fails is different from just returning non-zero exit code (`assert` _aborts_). Any ideas?
Repository:
rL LLVM
https://reviews.llvm.org/D53620
More information about the llvm-commits
mailing list