[PATCH] D53407: [llvm-mca] Move namespace mca inside llvm::

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 04:11:21 PDT 2018


andreadb added a comment.

In https://reviews.llvm.org/D53407#1272829, @MaskRay wrote:

> Friendly ping :)


Hi!

Thanks for the patch.

I am okay with this change provided that you only change files in `llvm-mca/include` or in `llvm-mca/lib`.
There is a plan to move the core abstractions of llvm-mca into llvm/lib (at some point; hopefully in the near future). So, files that are not part of the library (for example, Views) should not be touched.

Also, if you are going to move `namespace mca` under `namespace llvm`, then please update the code by removing all the redundant `llvm::` prefixes.

Thanks,
-Andrea


Repository:
  rL LLVM

https://reviews.llvm.org/D53407





More information about the llvm-commits mailing list