[PATCH] D53535: [MC] Separate masm integer literal lexer support from inline asm

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 23:01:06 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D53535#1273593, @rnk wrote:

> In https://reviews.llvm.org/D53535#1271972, @mstorsjo wrote:
>
> > FWIW, a different bug report where normal GNU non-inline assembly is broken by the MS inline asm handling is PR32973. It doesn't seem to get fixed by this change unfortunately - I haven't dug any further to see how closely related the issues are; that's also a case where e.g. `8h` gets treated as a hex literal and gets replaced by `8` where it definitely shouldn't - where no intel syntax is involved whatsoever.
>
>
> I looked at the code, and there was extra 'h' hex literal handling that wasn't conditionalized the way it was supposed to be. Hopefully this new patch addresses it.


Nice! Indeed, it does seem to be fixed by this change now. Thanks!


https://reviews.llvm.org/D53535





More information about the llvm-commits mailing list