[PATCH] D53424: Enable thread specific cl::opt values for multi-threaded support
Yevgeny Rouban via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 23 21:00:38 PDT 2018
yrouban added a comment.
In https://reviews.llvm.org/D53424#1273728, @jfb wrote:
> Was there a commitment from the community, with some time horizon for moving away from this patch?
Frankly speaking, I do not think that this kind of transition can be done easily. Every single option needs a big change. That is the biggest disadvantage of the feature https://reviews.llvm.org/D5389. It needs some improvements to allow enough flexibility. And we cannot know what improvements are needed until we implement enough options in the new way. I do not see any good way to force the transition to finish in a fixed time frame. If https://reviews.llvm.org/D5389 were easy to use and transit to, it would have been already adopted and we would not have to came up with another idea like this https://reviews.llvm.org/D53424.
In other words, I would give the new idea a try (at least under a preprocessor flag).
Repository:
rL LLVM
https://reviews.llvm.org/D53424
More information about the llvm-commits
mailing list