[PATCH] D52915: [PM] keeping history when original SCC split and then merge into itself in the same round of SCC update .

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 16:02:27 PDT 2018


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Sorry for delay...

I'm still curious if there is a good reason why we are re-adding the SCC to the worklist (there may be! just hard to think through it all), but it does seem fine to just directly catch the cycle and block it here, and is the minimal change that should fix things. LGTM.



================
Comment at: lib/Transforms/IPO/Inliner.cpp:1168
+    // into the same one as itself. and the original SCC will be added into
+    // UR.CWorklist again, we want to cache such case too.
+    //
----------------
nit: s/cache/catch/, s/case/cases/


Repository:
  rL LLVM

https://reviews.llvm.org/D52915





More information about the llvm-commits mailing list