[PATCH] D53519: [CodeGen] skip lifetime end marker in isInTailCallPosition

[Robert Lougher via Phabricator via llvm-commits]

rob.lougher added a comment.

In https://reviews.llvm.org/D53519#1273358, @rob.lougher wrote:

> In https://reviews.llvm.org/D53519#1273062, @probinson wrote:
>
> > In https://reviews.llvm.org/D53519#1272775, @rnk wrote:
> >
> > > Is there some more general property for us to check that this intrinsic shares with other annotation-like intrinsics like llvm.assume?
> >
> >
> > I have a memory that somebody wanted an expands-to-nothing property, or generates-no-instructions, or something along those lines. That's probably the kind of generic property you're asking about here?  I don't remember the context or outcome, unfortunately.
>
>
> See my previous comment about ad hoc checks of intrinsic IDs in stack protector, loop vectorizer, etc.


I can find no such property, and code which wants to skip such intrinsics uses explicit intrinsic ID checks, which again implies no such property exists. Debug intrinsics are commonly skipped (as they don't generate code). Other non-code intrinsics have been added as needed/discovered as in https://reviews.llvm.org/D45331. Like the stack protector, isInTailCallPosition has a check for debug intrinsics. This patch simply adds an additional intrinsic check for lifetime_end in the same manner.


Repository:
  rL LLVM

https://reviews.llvm.org/D53519