[llvm] r345079 - [llvm-objcopy] Fix use-after-move clang-tidy warning

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 13:54:51 PDT 2018


Author: rupprecht
Date: Tue Oct 23 13:54:51 2018
New Revision: 345079

URL: http://llvm.org/viewvc/llvm-project?rev=345079&view=rev
Log:
[llvm-objcopy] Fix use-after-move clang-tidy warning

Modified:
    llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp

Modified: llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp?rev=345079&r1=345078&r2=345079&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/CopyConfig.cpp Tue Oct 23 13:54:51 2018
@@ -345,8 +345,6 @@ DriverConfig parseObjcopyOptions(ArrayRe
 
   Config.PreserveDates = InputArgs.hasArg(OBJCOPY_preserve_dates);
 
-  DriverConfig DC;
-  DC.CopyConfigs.push_back(std::move(Config));
   if (Config.DecompressDebugSections &&
       Config.CompressionType != DebugCompressionType::None) {
     error("Cannot specify --compress-debug-sections at the same time as "
@@ -356,6 +354,8 @@ DriverConfig parseObjcopyOptions(ArrayRe
   if (Config.DecompressDebugSections && !zlib::isAvailable())
     error("LLVM was not compiled with LLVM_ENABLE_ZLIB: cannot decompress.");
 
+  DriverConfig DC;
+  DC.CopyConfigs.push_back(std::move(Config));
   return DC;
 }
 




More information about the llvm-commits mailing list