[PATCH] D53408: [PPC64] Long branch thunks.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:3086
+bool PPC64LongBranchTargetSection::empty() const {
+  return Finalized && Entries.size() == 0;
+}
----------------
`Entries.size() == 0` -> `Entries.empty()`


================
Comment at: test/ELF/ppc64-long-branch.s:5
+# RUN: llvm-mc -filetype=obj -triple=powerpc64le-unknown-linux %p/Inputs/ppc64-func-global-entry.s -o %t2.o
+# RUN: ld.lld  -shared %t2.o  -o %t3
+# RUN: ld.lld --no-toc-optimize %t.o %t3 -o %t
----------------
Name shared object `*.so`


================
Comment at: test/ELF/ppc64-long-branch.s:66
+
+        .section        .toc,"aw", at progbits
+.LC0:
----------------
The indentation (this section and the instructions below `.localentry`) does not look good in Phabricator. Is it intended?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53408