[PATCH] D53446: Set MAttrs in LTO mode

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 13:07:52 PDT 2018


ruiu added inline comments.


================
Comment at: Common/TargetOptionsCommandFlags.cpp:36
+
+std::vector<std::string> lld::GetMAttrs(){
+  std::vector<std::string> Attrs;
----------------
yinma wrote:
> MaskRay wrote:
> > `return std::vector<std::string>(MAttrs.begin(), MAttrs.end());`
> OK
Please format carefully -- you need a space between `()` and the following `{`. I'd recommend clang-format-diff if you are not using it already.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53446





More information about the llvm-commits mailing list