[llvm] r345054 - [PDB] Fix -Wunused-private-field in DIA
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 23 10:20:16 PDT 2018
Author: rnk
Date: Tue Oct 23 10:20:16 2018
New Revision: 345054
URL: http://llvm.org/viewvc/llvm-project?rev=345054&view=rev
Log:
[PDB] Fix -Wunused-private-field in DIA
Modified:
llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h
llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h
llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp
llvm/trunk/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp
llvm/trunk/lib/DebugInfo/PDB/DIA/DIASession.cpp
Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h?rev=345054&r1=345053&r2=345054&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h Tue Oct 23 10:20:16 2018
@@ -17,12 +17,9 @@
namespace llvm {
namespace pdb {
-class DIASession;
-
class DIAEnumFrameData : public IPDBEnumChildren<IPDBFrameData> {
public:
- explicit DIAEnumFrameData(const DIASession &PDBSession,
- CComPtr<IDiaEnumFrameData> DiaEnumerator);
+ explicit DIAEnumFrameData(CComPtr<IDiaEnumFrameData> DiaEnumerator);
uint32_t getChildCount() const override;
ChildTypePtr getChildAtIndex(uint32_t Index) const override;
@@ -30,7 +27,6 @@ public:
void reset() override;
private:
- const DIASession &Session;
CComPtr<IDiaEnumFrameData> Enumerator;
};
Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h?rev=345054&r1=345053&r2=345054&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h Tue Oct 23 10:20:16 2018
@@ -20,8 +20,7 @@ class DIASession;
class DIAFrameData : public IPDBFrameData {
public:
- explicit DIAFrameData(const DIASession &PDBSession,
- CComPtr<IDiaFrameData> DiaFrameData);
+ explicit DIAFrameData(CComPtr<IDiaFrameData> DiaFrameData);
uint32_t getAddressOffset() const override;
uint32_t getAddressSection() const override;
@@ -31,7 +30,6 @@ public:
uint64_t getVirtualAddress() const override;
private:
- const DIASession &Session;
CComPtr<IDiaFrameData> FrameData;
};
Modified: llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp?rev=345054&r1=345053&r2=345054&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp Tue Oct 23 10:20:16 2018
@@ -13,9 +13,8 @@
using namespace llvm::pdb;
-DIAEnumFrameData::DIAEnumFrameData(const DIASession &PDBSession,
- CComPtr<IDiaEnumFrameData> DiaEnumerator)
- : Session(PDBSession), Enumerator(DiaEnumerator) {}
+DIAEnumFrameData::DIAEnumFrameData(CComPtr<IDiaEnumFrameData> DiaEnumerator)
+ : Enumerator(DiaEnumerator) {}
uint32_t DIAEnumFrameData::getChildCount() const {
LONG Count = 0;
@@ -28,7 +27,7 @@ DIAEnumFrameData::getChildAtIndex(uint32
if (S_OK != Enumerator->Item(Index, &Item))
return nullptr;
- return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Session, Item));
+ return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Item));
}
std::unique_ptr<IPDBFrameData> DIAEnumFrameData::getNext() {
@@ -37,7 +36,7 @@ std::unique_ptr<IPDBFrameData> DIAEnumFr
if (S_OK != Enumerator->Next(1, &Item, &NumFetched))
return nullptr;
- return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Session, Item));
+ return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Item));
}
void DIAEnumFrameData::reset() { Enumerator->Reset(); }
Modified: llvm/trunk/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp?rev=345054&r1=345053&r2=345054&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp Tue Oct 23 10:20:16 2018
@@ -13,9 +13,8 @@
using namespace llvm::pdb;
-DIAFrameData::DIAFrameData(const DIASession &PDBSession,
- CComPtr<IDiaFrameData> DiaFrameData)
- : Session(PDBSession), FrameData(DiaFrameData) {}
+DIAFrameData::DIAFrameData(CComPtr<IDiaFrameData> DiaFrameData)
+ : FrameData(DiaFrameData) {}
template <typename ArgType>
ArgType
Modified: llvm/trunk/lib/DebugInfo/PDB/DIA/DIASession.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/DIA/DIASession.cpp?rev=345054&r1=345053&r2=345054&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/DIA/DIASession.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/DIA/DIASession.cpp Tue Oct 23 10:20:16 2018
@@ -428,5 +428,5 @@ DIASession::getFrameData() const {
if (!FD)
return nullptr;
- return llvm::make_unique<DIAEnumFrameData>(*this, FD);
+ return llvm::make_unique<DIAEnumFrameData>(FD);
}
More information about the llvm-commits
mailing list