[PATCH] D53557: [hurd] Make getMainExecutable get the real binary path

Samuel Thibault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 09:18:35 PDT 2018


sthibaul updated this revision to Diff 170674.

https://reviews.llvm.org/D53557

Files:
  lib/Support/Unix/Path.inc


Index: lib/Support/Unix/Path.inc
===================================================================
--- lib/Support/Unix/Path.inc
+++ lib/Support/Unix/Path.inc
@@ -180,8 +180,26 @@
   if (sys::fs::exists(aPath)) {
       // /proc is not always mounted under Linux (chroot for example).
       ssize_t len = readlink(aPath.str().c_str(), exe_path, sizeof(exe_path));
-      if (len >= 0)
-          return std::string(exe_path, len);
+      if (len >= 0) {
+          if (len >= sizeof(exe_path))
+              len = sizeof(exe_path)-1;
+          exe_path[len] = '\0';
+
+          // At least on GNU/Hurd, /proc/self/exe is a symlink to the path that
+          // was used to start the program, and not the eventual binary file.
+          // We thus needs to run realpath over it to get the actual place
+          // where llvm was installed.
+#if _POSIX_VERSION >= 200112 || defined(__GLIBC__)
+          char *real_path = realpath(exe_path, NULL);
+          std::string ret = std::string(real_path);
+          free(real_path);
+          return ret;
+#else
+          char real_path[MAXPATHLEN];
+          realpath(exe_path, real_path);
+          return std::string(real_path);
+#endif
+      }
   } else {
       // Fall back to the classical detection.
       if (getprogpath(exe_path, argv0))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53557.170674.patch
Type: text/x-patch
Size: 1308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181023/f8a929bc/attachment.bin>


More information about the llvm-commits mailing list