[PATCH] D31068: [SDAG] Expand MergedConsecutiveStores to better handle Giving up in Chain Analysis

[Nirav Dave via Phabricator via llvm-commits]

niravd added a comment.

It's certainly less likely than before, but it does happen in the wild, but https://reviews.llvm.org/D53552 should always parallelize these store chains, so this this should be droppable.

In https://reviews.llvm.org/D31068#1272588, @courbet wrote:

> In https://reviews.llvm.org/D31068#1267984, @niravd wrote:
>
> > Rebase to head. Some changes to alias make this require a much longer chain of stores. The need is clearly less than when I wrote this patch a year ago, but still has a minor positive effect.
>
>
> Do you think likely to happen in practice ?




In https://reviews.llvm.org/D31068#1272588, @courbet wrote:

> In https://reviews.llvm.org/D31068#1267984, @niravd wrote:
>
> > Rebase to head. Some changes to alias make this require a much longer chain of stores. The need is clearly less than when I wrote this patch a year ago, but still has a minor positive effect.
>
>
> Do you think likely to happen in practice ?





Repository:
  rL LLVM

https://reviews.llvm.org/D31068