[PATCH] D53557: [hurd] Make getMainExecutable get the real binary path

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I think doing this everywhere is fine.



================
Comment at: lib/Support/Unix/Path.inc:188
+
+#if _POSIX_VERSION >= 200112 || defined(__GLIBC__)
+          char *real_path = realpath(exe_path, NULL);
----------------
Can you add a comment explaining that Hurd needs this realpath call as you have in the commit message? Otherwise some well-meaning person will try to simplify the code and break Hurd.


Repository:
  rL LLVM

https://reviews.llvm.org/D53557