[llvm] r345041 - [SelectionDAG] use 'match' to simplify code; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 23 08:46:10 PDT 2018
Author: spatel
Date: Tue Oct 23 08:46:10 2018
New Revision: 345041
URL: http://llvm.org/viewvc/llvm-project?rev=345041&view=rev
Log:
[SelectionDAG] use 'match' to simplify code; NFC
Vector types are not possible here because this code only starts
matching from the scalar bool value of a conditional branch, but
this is another step towards completely removing the fake binop
queries for not/neg/fneg.
Modified:
llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=345041&r1=345040&r2=345041&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Tue Oct 23 08:46:10 2018
@@ -88,6 +88,7 @@
#include "llvm/IR/Metadata.h"
#include "llvm/IR/Module.h"
#include "llvm/IR/Operator.h"
+#include "llvm/IR/PatternMatch.h"
#include "llvm/IR/Statepoint.h"
#include "llvm/IR/Type.h"
#include "llvm/IR/User.h"
@@ -121,6 +122,7 @@
#include <vector>
using namespace llvm;
+using namespace PatternMatch;
#define DEBUG_TYPE "isel"
@@ -1824,7 +1826,6 @@ SelectionDAGBuilder::EmitBranchForMerged
SwitchCases.push_back(CB);
}
-/// FindMergedConditions - If Cond is an expression like
void SelectionDAGBuilder::FindMergedConditions(const Value *Cond,
MachineBasicBlock *TBB,
MachineBasicBlock *FBB,
@@ -1836,13 +1837,12 @@ void SelectionDAGBuilder::FindMergedCond
bool InvertCond) {
// Skip over not part of the tree and remember to invert op and operands at
// next level.
- if (BinaryOperator::isNot(Cond) && Cond->hasOneUse()) {
- const Value *CondOp = BinaryOperator::getNotArgument(Cond);
- if (InBlock(CondOp, CurBB->getBasicBlock())) {
- FindMergedConditions(CondOp, TBB, FBB, CurBB, SwitchBB, Opc, TProb, FProb,
- !InvertCond);
- return;
- }
+ Value *NotCond;
+ if (match(Cond, m_OneUse(m_Not(m_Value(NotCond)))) &&
+ InBlock(NotCond, CurBB->getBasicBlock())) {
+ FindMergedConditions(NotCond, TBB, FBB, CurBB, SwitchBB, Opc, TProb, FProb,
+ !InvertCond);
+ return;
}
const Instruction *BOp = dyn_cast<Instruction>(Cond);
More information about the llvm-commits
mailing list