[PATCH] D53136: [LNT] Come up with MIN_PERCENTAGE_CHANGE value

[Martin Liška via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL345006: Come up with MIN_PERCENTAGE_CHANGE value. (authored by marxin, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D53136?vs=169198&id=170575#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53136

Files:
  lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
  lnt/trunk/lnt/server/reporting/analysis.py


Index: lnt/trunk/lnt/server/reporting/analysis.py
===================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py
+++ lnt/trunk/lnt/server/reporting/analysis.py
@@ -15,6 +15,8 @@
 # The smallest measureable change we can detect in seconds.
 MIN_VALUE_PRECISION = 0.0001
 
+# Minimal percentage difference that is visible in reports
+MIN_PERCENTAGE_CHANGE = .01
 
 def absmin_diff(current, prevs):
     """Min of differences between current sample and all previous samples.
@@ -183,16 +185,16 @@
         elif self.prev_failed:
             return UNCHANGED_PASS
 
-        # Always ignore percentage changes below 1%, for now, we just don't
+        # Always ignore percentage changes below MIN_PERCENTAGE_CHANGE %, for now, we just don't
         # have enough time to investigate that level of stuff.
-        if ignore_small and abs(self.pct_delta) < .01:
+        if ignore_small and abs(self.pct_delta) < MIN_PERCENTAGE_CHANGE:
             return UNCHANGED_PASS
 
         # Always ignore changes with small deltas. There is no mathematical
         # basis for this, it should be obviated by appropriate statistical
         # checks, but practical evidence indicates what we currently have isn't
         # good enough (for reasons I do not yet understand).
-        if ignore_small and abs(self.delta) < .01:
+        if ignore_small and abs(self.delta) < MIN_PERCENTAGE_CHANGE:
             return UNCHANGED_PASS
 
         # Ignore tests whose delta is too small relative to the precision we
Index: lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
===================================================================
--- lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
+++ lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
@@ -9,15 +9,15 @@
 from lnt.server.db.testsuitedb import TestSuiteDB
 from lnt.testing.util.commands import timed
 from lnt.util import logger
-
+from lnt.server.reporting.analysis import MIN_PERCENTAGE_CHANGE
 
 def _fixed_rind(session, ts, rind):
     """Is this regression indicator fixed?"""
     fc = rind.field_change
     if fc is None:
         return False
     current_cr, _, _ = get_cr_for_field_change(session, ts, fc, current=True)
-    if current_cr.pct_delta < 0.01:
+    if current_cr.pct_delta < MIN_PERCENTAGE_CHANGE:
         return True
     else:
         return False


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53136.170575.patch
Type: text/x-patch
Size: 2416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181023/09cc9c57/attachment.bin>