[PATCH] D53418: [AMDGPU] Defined gfx909 Raven Ridge 2

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added a comment.

This also requires a clang change.



================
Comment at: docs/AMDGPUUsage.rst:596-597
      ``EF_AMDGPU_MACH_AMDGCN_GFX906``  0x02f      ``gfx906``
-     *reserved*                        0x030      Reserved.
+     ``EF_AMDGPU_MACH_AMDGCN_GFX909``  0x030      ``gfx909``
+     *reserved*                        0x031      Reserved.
      ================================= ========== =============================
----------------
Make 0x030 reserved.
Make 0x031 gfx909.


================
Comment at: include/llvm/BinaryFormat/ELF.h:704
   EF_AMDGPU_MACH_AMDGCN_GFX906 = 0x02f,
+  EF_AMDGPU_MACH_AMDGCN_GFX909 = 0x030,
 
----------------
Can you change it 0x031?


================
Comment at: include/llvm/BinaryFormat/ELF.h:708
   EF_AMDGPU_MACH_AMDGCN_RESERVED0 = 0x027,
-  EF_AMDGPU_MACH_AMDGCN_RESERVED1 = 0x030,
+  EF_AMDGPU_MACH_AMDGCN_RESERVED1 = 0x031,
 
----------------
Can you change it to 0x030?


================
Comment at: include/llvm/Support/TargetParser.h:323
   GK_AMDGCN_FIRST = GK_GFX600,
   GK_AMDGCN_LAST = GK_GFX906,
 };
----------------
This needs to be updated.


Repository:
  rL LLVM

https://reviews.llvm.org/D53418