[PATCH] D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:2724
+  // if the exceptional code was optimized away, in which case we just return
+  // the incoming EBP.
+  if (!Fn->hasPersonalityFn())
----------------
It's not EBP for AArch64, surely. I would generalize the text to "FP" instead.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:2731-2732
+  MCSymbol *OffsetSym =
+      MF.getMMI().getContext().getOrCreateParentFrameOffsetSymbol(
+          GlobalValue::dropLLVMManglingEscape(Fn->getName()));
+  SDValue OffsetSymVal = DAG.getMCSymbol(OffsetSym, PtrVT);
----------------
Yeah, this was a great hack. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D53540