[PATCH] D53307: [WebAssembly] Remove WebAssemblyStackifier TableGen backend

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel accepted this revision.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrFormats.td:21
+  bits<32> Inst = inst; // Instruction encoding.
+  string StackBased = stack;
+  string BaseName = NAME;
----------------
tlively wrote:
> aardappel wrote:
> > Why does this need to be a string instead of a bit?
> I specified that the values of the `StackBased` form the columns of the relational mapping. Internally, TableGen will uses these values to form identifiers in an enum. I guess since the values are used as part of identifiers, TableGen requires them to be strings. It seemed better to make this field a string than to introduce a redundant string field that contains the same information.
Ah ok, thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D53307