[PATCH] D53470: [ELF] Don't warn on two legitimate cases when reading .llvm.call-graph-profile

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:693
+      auto *ToSec = dyn_cast_or_null<InputSectionBase>(ToSym->Section);
+      // The profile from .llvm.call-graph-profile is conceptually affiliated to
+      // FromSec. Don't warn unorderable symbol if FromSym is not absolute
----------------
When you write a multi-line comment, please add a blank line before first line.


================
Comment at: ELF/Driver.cpp:696
+      // (FromSec isn't null) and the section is discarded (!FromSec->Repl->Live
+      // ).
+      //
----------------
You generally shouldn't break a line before ")".


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53470