[PATCH] D53444: Support ARM_V4BX relocation

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 22 14:24:12 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/Arch/ARM.cpp:520-521
+  case R_ARM_V4BX:
+    // V4BX records the location of an ARMv4t BX Instruction
+    // No computation is needed.
+    break;
----------------
Please elaborate a bit more based on Eli's comment. I'd write

  V4BX is just a marker to indicate there's a "bx rN" instruction at the given address. It can be used to implement a special linker mode which rewrites ARMv4T inputs to ARMv4. Since we support only ARMv4 input and not ARMv4 output, we can just ignore it.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53444





More information about the llvm-commits mailing list