[PATCH] D45213: [COFF][LLD] Add link support for precompiled headers .objs

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 22 14:17:18 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D45213#1269836, @neerajksingh wrote:

> FYI, in the MS linker, we find out early on that a file contains precompiled type information from the presence of the debug$P section and mostly process those files before processing the non-PCT files.  That avoids some need to search when acquiring the PCH data.


Thanks, that's interesting.



================
Comment at: llvm/trunk/lib/DebugInfo/CodeView/TypeStreamMerger.cpp:100
+                         ArrayRef<GloballyHashedType> Hashes,
+                         Optional<EndPrecompRecord> &EP);
 
----------------
I was hoping to come up with some way to avoid the extra out parameter, but that's my only real concern. Structurally, everything else looks like type servers, and it's pretty straightforward.


https://reviews.llvm.org/D45213





More information about the llvm-commits mailing list