[PATCH] D53155: [DWARF] Make llvm-dwarfdump display location lists in a .dwp file correctly. Fixes PR38990.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/trunk/lib/DebugInfo/DWARF/DWARFUnit.cpp:183-188
+  if (IsDWO) {
+    LocSectionData = LocSection->Data;
+    if (auto *IndexEntry = Header.getIndexEntry())
+      if (const auto *C = IndexEntry->getOffset(DW_SECT_LOC))
+        LocSectionData = LocSectionData.substr(C->Offset, C->Length);
+  }
----------------
Not sure if I mentioned this, but any chance we could generalize this solution for all contribution/unit index handling? (so unindexed sections are passed into the ctor here, but they're all converted to indexed offset sections from here on out?) For example the str_offsets section handling in extractDIEsIfNeeded could be moved up here, maybe?


Repository:
  rL LLVM

https://reviews.llvm.org/D53155