[PATCH] D52999: [FileCheck] Annotate input dump
George Karpenkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 22 10:48:21 PDT 2018
george.karpenkov added a comment.
@jdenny
> I'm willing to split up the patch more if it helps the review
Yes please, to be honest I can't still fully understand the feature description, let alone the code.
I have asked my colleague to take a glance, and his verdict was the same, so I'm not alone there.
You have a lot of new features in your FileCheck output; could you think of a way to separate them into simple, small, understandable chunks?
https://reviews.llvm.org/D52999
More information about the llvm-commits
mailing list