[PATCH] D53478: [DAGCombine] SimplifyNodeWithTwoResults - ensure same legalization for LO/HI operands (PR21207)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 22 08:19:42 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D53478#1270752, @niravd wrote:

> I don't think that need to avoid custom operations post-legalization. The documentation doesn't seem to address this, but as I understand it, Custom is Legal but with non-standard lowering and we just happen to lower custom node in legalize as an easy way to sure we've legalized the DAG.


I don't think we have any other cases in DAGCombiner where we use !LegalOperations || TLI.isOperationLegalOrCustom


Repository:
  rL LLVM

https://reviews.llvm.org/D53478





More information about the llvm-commits mailing list