[PATCH] D52677: [AMDGPU] Match v_swap_b32

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked 2 inline comments as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.h:286
+  MachineOperand *YTop = nullptr;
+  for (MachineOperand &Op : MRI.use_operands(T)) {
+    if (Op.getSubReg() != Tsub) {
----------------
arsenm wrote:
> arsenm wrote:
> > use_nodbg_operands?
> I still see it as use_operands?
You are somehow looking at the old patch.


================
Comment at: test/CodeGen/AMDGPU/v_swap_b32.mir:521
+    %1.sub0 = COPY %2.sub0
+...
+
----------------
arsenm wrote:
> %2 needs another use which might break
What can be a valid implicit use for a COPY besides exec?


https://reviews.llvm.org/D52677