[PATCH] D53112: [NFC] Rename minnan and maxnan to minimum and maximum
Thomas Lively via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 19 15:25:56 PDT 2018
tlively added a comment.
In https://reviews.llvm.org/D53112#1268114, @aheejin wrote:
> - I guess this should be marked as NFC
Done
> - Does this mean you'd like to match the semantics of the existing `minnan`/`maxnan` in the backend to match the new `minimum`/`maximum` intrinsics? Then are you planning to update ValueTracking optimizations for them as well?
This semantic matching already happened when we merged the new intrinsics, since they already lower directly to these SD nodes. I was not planning on updating the ValueTracking optimizations, although I could look into it. The current optimizations are still correct because they are too conservative, if anything.
Repository:
rL LLVM
https://reviews.llvm.org/D53112
More information about the llvm-commits
mailing list