[PATCH] D53227: [hwasan] add stack frame descriptions.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:318
+    // W/o it we would have to create the call to __hwasan_init_frames after
+    // all functions are instrumented (i.e. need to have a ModulePass).
+    createFD(*HwasanCtorFunction, "");
----------------
morehouse wrote:
> Why do we need a frame description for the ctor in order to call it?
We don't. 
This call is here to ensure that the section is not empty and that we can create __start_SECTION for it. 
Otherwise, we will need to refactor the code to make it a ModulePass instead of a FunctionPass (which is unwelcome). 
I don't know any other way to handle this in a FunctionPass. :( 


Repository:
  rL LLVM

https://reviews.llvm.org/D53227