[PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In https://reviews.llvm.org/D53311#1266757, @alexshap wrote:

> @jhenderson, i can try to split it into several diffs, the biggest part is number 1, number 2 + 3 are about 30 lines of code (combined), number 4 is easy to split out.


It looks like you're still trying to do the dispatch changes and the refactoring into a separate file changes in the same patch. I'd still prefer those to be two different ones.



================
Comment at: ELFObjcopy.cpp:453
+      auto File = SecPair.second;
+      auto BufOrErr = ::llvm::MemoryBuffer::getFile(File);
+      if (!BufOrErr)
----------------
What's the reason for the extra namespacing here? It wasn't there before.


Repository:
  rL LLVM

https://reviews.llvm.org/D53311