[PATCH] D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info.

[Chirag Patel via Phabricator via llvm-commits]

Chirag added inline comments.


================
Comment at: include/llvm/IR/DebugInfoFlags.def:54
 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed)
+HANDLE_DI_FLAG((1 << 30), BinaryScale)
 
----------------
aprantl wrote:
> The space in DIFLags is precious. Can you explain why we need this as a generic DIFlag and not just a bit in DIBasicType?
Thanks for reply. i am thinking this is a bad design as data seems scattered and basicType is getting bloated also you are right about DIFlags' bit being reserved and used only in rare cases is not good.
i am thinking of adding new DIDecimalType class as you suggested earlier in DebugInfoMetaData.h inherited from Type and scrap this review if it is okay with you guys.



https://reviews.llvm.org/D52295