[PATCH] D53430: [llvm-exegesis] Mark second-form X87 instructions as unsupported.

[Clement Courbet via Phabricator via llvm-commits]

courbet created this revision.
courbet added a reviewer: gchatelet.
Herald added a subscriber: tschuett.

We only support the first form because we rely on information that is
only available there.


Repository:
  rL LLVM

https://reviews.llvm.org/D53430

Files:
  tools/llvm-exegesis/lib/X86/Target.cpp


Index: tools/llvm-exegesis/lib/X86/Target.cpp
===================================================================
--- tools/llvm-exegesis/lib/X86/Target.cpp
+++ tools/llvm-exegesis/lib/X86/Target.cpp
@@ -26,7 +26,14 @@
   if (OpcodeName.startswith("POPF") || OpcodeName.startswith("PUSHF") ||
       OpcodeName.startswith("ADJCALLSTACK"))
     return llvm::make_error<BenchmarkFailure>(
-        "Unsupported opcode: Push/Pop/AdjCallStack");
+        "unsupported opcode: Push/Pop/AdjCallStack");
+  // We do not handle second-form X87 instructions. We only handle first-form
+  // ones (_Fp), see comment in X86InstrFPStack.td.
+  for (const Operand &Op : Instr.Operands)
+    if (Op.isReg() && Op.isExplicit() &&
+        Op.getExplicitOperandInfo().RegClass == llvm::X86::RSTRegClassID)
+      return llvm::make_error<BenchmarkFailure>(
+          "unsupported second-form X87 instruction");
   return llvm::Error::success();
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53430.170181.patch
Type: text/x-patch
Size: 934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181019/adc10870/attachment.bin>