[PATCH] D53384: [PowerPC] Make no-PIC default to match GCC - CLANG
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 19 03:35:55 PDT 2018
nemanjai added a comment.
TL; DR: +1 from me for proceeding with this patch. If you don't hear any strong objections before next week, I'd say please update the test cases and we'll go ahead with this.
I think it is important to match what GCC is doing for two reasons.
1. This is just what users have come to expect and will typically use `-fPIC/-fpic` explicitly when they rely on this behaviour.
2. Most build systems that build both static and shared versions will use `-fPIC` explicitly for the shared library case and just omit the option (rather than adding `-fno-pic` for the static library case).
For the most part, things work the same on PPC between the two cases, but there are some important differences - not the least of which being tail-call optimizations. We do not want the PIC default to take away those optimization opportunities in builds where PIC truly doesn't matter.
https://reviews.llvm.org/D53384
More information about the llvm-commits
mailing list