[PATCH] D53425: Fix modules build of AVRAsmParser.cpp

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 19 02:33:29 PDT 2018


arichardson created this revision.
arichardson added a reviewer: dylanmckay.
Herald added a subscriber: llvm-commits.

Without this change I get the following error:

lib/Target/AVR/AVRGenAsmMatcher.inc:1135:1: error: redundant #include of module 'LLVM_Utils.Support.Format' appears within namespace 'llvm' [-Wmodules-import-nested-redundant]


Repository:
  rL LLVM

https://reviews.llvm.org/D53425

Files:
  lib/Target/AVR/AsmParser/AVRAsmParser.cpp


Index: lib/Target/AVR/AsmParser/AVRAsmParser.cpp
===================================================================
--- lib/Target/AVR/AsmParser/AVRAsmParser.cpp
+++ lib/Target/AVR/AsmParser/AVRAsmParser.cpp
@@ -34,8 +34,9 @@
 
 #define DEBUG_TYPE "avr-asm-parser"
 
-namespace llvm {
+using namespace llvm;
 
+namespace {
 /// Parses AVR assembly from a stream.
 class AVRAsmParser : public MCTargetAsmParser {
   const MCSubtargetInfo &STI;
@@ -245,6 +246,8 @@
   }
 };
 
+} // end anonymous namespace.
+
 // Auto-generated Match Functions
 
 /// Maps from the set of all register names to a register number.
@@ -708,5 +711,3 @@
   }
   return Match_InvalidOperand;
 }
-
-} // end of namespace llvm


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53425.170170.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181019/6dbf9ca3/attachment.bin>


More information about the llvm-commits mailing list