[PATCH] D53158: [buildbot, windows] Update the way the visual studio environment is set

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 18 17:47:40 PDT 2018


stella.stamenova updated this revision to Diff 170137.
stella.stamenova added a comment.

I updated the patch, so that it will not auto detect the VS installation unless explicitly requested. I also propagated the flag to all the builders that currently work with VS, so that it is available immediately if anyone chooses to create a buildbot with a newer VS installation.

Is there a way to test this (beyond running the logic locally) to make sure that all the bots will work correctly?

Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D53158

Files:
  buildbot/osuosl/master/config/builders.py
  zorg/buildbot/builders/ClangBuilder.py
  zorg/buildbot/builders/LLDBBuilder.py
  zorg/buildbot/builders/LLDBuilder.py
  zorg/buildbot/builders/SanitizerBuilderWindows.py
  zorg/buildbot/builders/UnifiedTreeBuilder.py
  zorg/buildbot/builders/Util.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53158.170137.patch
Type: text/x-patch
Size: 8774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181019/7a1a1a0d/attachment.bin>


More information about the llvm-commits mailing list