[PATCH] D53403: [llvm-objdump] Fix --file-headers (-f) option
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 18 14:24:08 PDT 2018
jhenderson added a comment.
LGTM, with one nit.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:2225
+ StringRef Fmt = o->getBytesInAddress() > 4 ? "%016" PRIx64 : "%08" PRIx64;
+ uint64_t address = StartAddrOrErr.get();
outs() << "start address: "
----------------
Nit: address -> Address, or just do this inline, I don't mind which.
https://reviews.llvm.org/D53403
More information about the llvm-commits
mailing list