[PATCH] D53216: [FPEnv] Add constrained intrinsics for MAXNUM and MINNUM

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 18 11:25:23 PDT 2018


kpn added inline comments.


================
Comment at: docs/LangRef.rst:14419
+                                            metadata <rounding mode>,
+                                            metadata <exception behavior>)
+
----------------
cameron.mcinally wrote:
> A quick note that the rounding mode doesn't apply to these intrinsics, but I suspect that this is really a larger problem. E.g. rint, nearbyint, etc also take a rounding mode argument but never use it. I suggest we handle that problem in an entirely separate patch for all constrained intrinsics at once.
Works for me. That sounds better than piecemeal like I started in D43515.


Repository:
  rL LLVM

https://reviews.llvm.org/D53216





More information about the llvm-commits mailing list