[PATCH] D53332: Access ADDLIB in llvm-ar via command line

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 18 06:03:07 PDT 2018


mstorsjo added inline comments.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:553
+    NMOrErr->MemberName = sys::path::filename(NMOrErr->MemberName);
+    Members.push_back(std::move(*NMOrErr));
+  }
----------------
gbreynoo wrote:
> mstorsjo wrote:
> > Any reason why this path can't just call the default `addMember`?
> It would mean repeating the getFile() call, I wasn't sure it was worth the overhead.
Ah, I see. That makes sense to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D53332





More information about the llvm-commits mailing list