[PATCH] D53332: Access ADDLIB in llvm-ar via command line

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Other than the minor comment I had, this looks sensible to me. Do we have any policy or predecent on adding this kind of custom additions to tools like `ar` from before? (I'd like to at least have some sort of ack from someone else to approve this.)



================
Comment at: tools/llvm-ar/llvm-ar.cpp:553
+    NMOrErr->MemberName = sys::path::filename(NMOrErr->MemberName);
+    Members.push_back(std::move(*NMOrErr));
+  }
----------------
Any reason why this path can't just call the default `addMember`?


Repository:
  rL LLVM

https://reviews.llvm.org/D53332