[PATCH] D53251: [WebAssembly] Custom lower i64x2 constant shifts to avoid wrap

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 17 11:55:26 PDT 2018


aheejin added a comment.

- Why do we need to do this? If there is an i64 that's stored in an i32 register, shouldn't we have `wrap` in that case?
- Some unrelated question: If the shift amount operand is not a splat vector, I think you said isel just crashes, right? Shouldn't we bail out to lower them in scalar operations?


Repository:
  rL LLVM

https://reviews.llvm.org/D53251





More information about the llvm-commits mailing list