[PATCH] D53240: [WebAssembly] WebAssemblyLowerEmscriptenEHSjLj: use getter/setter for accessing tempRet0
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 17 09:37:14 PDT 2018
aheejin added a comment.
Do you think all variables used to communicate between wasm and JS use not global variables but wasm globals? I'll repeat what I said in my previous comment:
> They are used to mean different things, and they don't even set the same thing (one sets a global variable in linear memory, and the other sets an wasm global). Should they share the same name in the first place?
I couldn't understand the motivation behind this change, that's all. This stemmed from my patch <https://github.com/kripken/emscripten/pull/7268> that tried to first eliminate seemingly unused `getTempRet0` and then tried to export it to be consistent with other methods, which broke another test. The reason that another test broke was because we are using `__tempRet0` for two different purpose. So I thought if we divide the variable the problem would be solved.
Sorry for unsolicited comments.
Repository:
rL LLVM
https://reviews.llvm.org/D53240
More information about the llvm-commits
mailing list