[PATCH] D53370: Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Mikael Holmén via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 17 06:13:16 PDT 2018
uabelho added a comment.
Was it something like this you had in mind Eli?
================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:1081-1082
else
R = isBinary ? emitBinaryFloatFnCall(V[0], V[1], CalleeNm, B, CalleeAt)
: emitUnaryFloatFnCall(V[0], CalleeNm, B, CalleeAt);
----------------
I don't know if these calls pose any problem? Since we use the name of the function that we already called I suppose we at least shouldn't end up with a name like ""?
Also since we can deal with many different kinds of lib functions here I'm not sure how messy it is to find the double/float/long double versions of the function and use the new interface?
Suggestions?
Repository:
rL LLVM
https://reviews.llvm.org/D53370
More information about the llvm-commits
mailing list