[PATCH] D53222: AMDGPU: Add sram-ecc feature

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: docs/AMDGPUUsage.rst:263
+                     feature disabled.
+     -m[no-]sram-ecc Enable/disable SRAM ECC.
+     =============== ==================================================
----------------
t-tye wrote:
> nhaehnle wrote:
> > Maybe better:
> > 
> > > Enable/disable compiling code that can run with SRAM ECC enabled.
> > 
> > After all, this option doesn't actually enable the ECC itself, it just makes sure to generate code that works with ECC is enabled. I think we should also mention that code compiled with -msram-ecc will be able to run both with and without ECC.
> > 
> > 
> Note that the SRAM ECC setting is being recorded in the code object and that the loader will not load a code object if the settings do not match the target device. This is the same for XNACK. The rational was that by default we don't want the loader to load code objects that will perform sub-optimally. If necessary we could implement options to the loader to ignore checks for developers, but then developers should know what is possible or not by consulting the hardware spec.
@t-tye, that makes sense.

Thanks for changing the text!


https://reviews.llvm.org/D53222